[ML] Display warning if clone job fails due to missing data view #117993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
darnautov
reviewed
Nov 9, 2021
| values: { jobId, dataViewTitle }, | ||
| } | ||
| ); | ||
| getToastNotifications().addDanger({ |
There was a problem hiding this comment.
should we use getToastNotificationService instead?
There was a problem hiding this comment.
Switched this one to getToastNotificationService in b67a413.
| public async assertNoDataViewForCloneJobWarningToastExist() { | ||
| await retry.tryForTime(5000, async () => { | ||
| const toast = await testSubjects.find('mlCloneJobNoDataViewExistsWarningToast'); | ||
| expect(toast).not.to.be(undefined); |
There was a problem hiding this comment.
do we need to check the content of the toast?
There was a problem hiding this comment.
I think it's ok just to check the data-test-subj for now, and this is in line with other tests we have for toast notifications.
darnautov
approved these changes
Nov 9, 2021
3 tasks
pheyos
reviewed
Nov 9, 2021
x-pack/test/functional/apps/ml/anomaly_detection/single_metric_job.ts
Outdated
Show resolved
Hide resolved
peteharverson
force-pushed
the
ml-clone-job-no-data-view-toast
branch
from
f6e1656
to
ae935aa
Compare
|
@elasticmachine merge upstream |
peteharverson
added
the
auto-backport
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 11, 2021
…stic#117993) * [ML] Display warning if clone job fails due to missing data view * [ML] Edits following review Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
…7993) * [ML] Display warning if clone job fails due to missing data view * [ML] Edits following review Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes regression introduced by #116455, adding back the warning toast if cloning an anomaly detection job fails because there is no data view matching the indices used in the datafeed.
Also adds a new functional test which would have caught the original regression.
Checklist
Fixes #117834